Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History and logbook increase and decrease timespan (Zoom Out / In) #23358

Conversation

boern99
Copy link
Contributor

@boern99 boern99 commented Dec 20, 2024

Breaking change

Proposed change

Increase and decrease the date-picker Timespan using Buttons
Desktop:
image

Mobile:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten added the Needs UX Pull requests requiring a review from the Home Assistant design team label Dec 22, 2024
@marcinbauer85
Copy link
Contributor

Thanks @boern99 for this contribution. I see there could be issues with users thinking the icons would zoom in/out the charts. Also this is a pattern that I personally never come upon, so it's not clear for me how this would work. Do you have some real world examples that use this pattern?
I see that I would have difficulties doing date/time math to see what is my current set range, because we use absolute start/end in the date textfield rather than a user-friendly approach like "Last 2 days".

@boern99
Copy link
Contributor Author

boern99 commented Jan 28, 2025

@marcinbauer85: Real World example is to quickly get an overview of a longer period / a past time range: by simply clicking on "Zoom out" having all charts synchronized: chrome_TJ9qAN7GfV.webm
another tool using a similar pattern is grafana:
image

@marcinbauer85
Copy link
Contributor

Thank you @boern99. Currently, we don't see a need to add this kind of functionality for the current date picker, the need and UX is not there yet. We might get back to this when we re-work the date-picker on a more in-depth level.

@boern99
Copy link
Contributor Author

boern99 commented Feb 11, 2025

Thank you @boern99. Currently, we don't see a need to add this kind of functionality for the current date picker, the need and UX is not there yet. We might get back to this when we re-work the date-picker on a more in-depth level.

@marcinbauer85: As you certainly have a deeper insight into the planned features of Home Assistant and maybe there are details I do not know:
For example: an update to the charts with the function to be able to scroll to an earlier time frame, synchronized across all charts, would of course make this commit obsolete …
Just to understand your decision, maybe you can answer this question for me: Is a similar functionality planned for the charts in the near future?

@marcinbauer85
Copy link
Contributor

@boern99 yes, you are correct. We have plans to add similar functionality at some point. The way you have proposed and how Grafana does it didn't convince us it's a good solution for average users.
That said, your other PR about presets sparked a conversation and in the end a user test to verify it with users. We're on track there and close to merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Needs UX Pull requests requiring a review from the Home Assistant design team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants