-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timespans to history and energy #23362
Add timespans to history and energy #23362
Conversation
Could you please also add back the "Yesterday", "Last week", "Last month" and "Last year" selectors as well as it used to be? Up to 2024.12 it was also present with the ones you to propose to add back. In 2024.12 and earlier all were there. Many times we're curious about full calendar units, not just the time span ending in the current point in time. My issue in the subject: #23671. Similar issues affecting the same UI component: #23685, #23685. Reference: |
The Idea was, that you simple can use Today and click the back button for yesterday: once more you would also have the day before yesterday and so forth. This works also for Week, Month, and Year. Removing "Yesterday", "Last week", "Last month" and "Last year" gives enough space for additional options: last 24h, last 30days, last 365days and keeps the list clear. |
Well, that makes sense. One more mouse click/tap, tho... |
Thanks, @boern99, for this contribution. It's a good idea, although this exposes a wider issue of this "dropdown" being too long for mobile currently, and the addition of more items - will make it worse: |
@boern99 based on the community research that I've did here we've concluded the presets that we would like to implement in both Logbook and History views. In reference to what you've submitted, the "Last 365 days" wasn't a popular choice, but the other two did make the cut. |
Last 365 days is more helpful for the energy dashboard anyway. |
Had to remove 7d for energy, as calculation cannot handle it: |
@boern99 please apply mobile only changes so that the list isn't that long, since after adding those items it doesn't fit on the screen. Once we have that we can merge this. Thank you. |
@marcinbauer85 : not sure what you mean: Can you please respond to my question in the review i opened and answer details about whats missing or wrong. |
@boern99 ah sorry, I saw the screen you posted and I didn't see that you have already added a rule for mobile 👍 |
* add Last 24h, 30d, 1y and overflow * added Energy-Dashboard * mobile style css * added yesterday and min-height; changed overflow; new timespans to end; * conflict resolve trial * changed energy timespan order * min for logbook * seperated overflow calc for energy and logbook / history * rename to header-position * prettier format * date-fns types * added 1h, 12 h, 7d and removed 365d for history, added 7d to energy * remove 7d for energy * use calcdate and for energy whole hours / days / months * fix calc
Breaking change
Proposed change
Type of change
adds som additional Date-Selections: Last 24 hours, Last 30 days and Last 365 days to History, Logbook and Energy-Dashbaord

Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: