-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding restore use core api #23920
Open
wendevlin
wants to merge
37
commits into
dev
Choose a base branch
from
backup-onboarding-core
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00f3362
to
ecf861f
Compare
19 tasks
62c2406
to
474cfb2
Compare
bramkragten
reviewed
Jan 29, 2025
bramkragten
reviewed
Feb 6, 2025
src/onboarding/restore-backup/onboarding-restore-backup-status.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Feb 6, 2025
bramkragten
reviewed
Feb 6, 2025
src/onboarding/restore-backup/onboarding-restore-backup-upload.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Feb 6, 2025
bramkragten
reviewed
Feb 6, 2025
bramkragten
reviewed
Feb 6, 2025
bramkragten
reviewed
Feb 6, 2025
src/panels/config/backup/components/ha-backup-details-restore.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Feb 6, 2025
bramkragten
reviewed
Feb 6, 2025
bramkragten
reviewed
Feb 6, 2025
bramkragten
reviewed
Feb 6, 2025
src/panels/config/backup/components/ha-backup-details-restore.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Feb 6, 2025
src/panels/config/backup/components/ha-backup-details-restore.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Feb 6, 2025
src/panels/config/backup/components/ha-backup-details-restore.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Feb 6, 2025
src/panels/config/backup/components/ha-backup-details-restore.ts
Outdated
Show resolved
Hide resolved
bramkragten
reviewed
Feb 6, 2025
bramkragten
reviewed
Feb 6, 2025
@@ -154,7 +162,7 @@ export class DialogUploadBackup | |||
|
|||
this._uploading = true; | |||
try { | |||
await uploadBackup(this.hass!, file, agentIds); | |||
await uploadBackup(file, agentIds, this.hass); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hass
is optional right? Should be typed correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No why? backup panel will always have hass right?
bramkragten
reviewed
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend merged
The backend PR for this frontend PR has been merged
cla-signed
Supervisor
Related to the supervisor panel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Use new core onboarding api to upload and restore backups
core PR: Add backup endpoints to the onboarding integration core#136051
core PRs persist restore info
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: