Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding restore use core api #23920

Open
wants to merge 37 commits into
base: dev
Choose a base branch
from
Open

Onboarding restore use core api #23920

wants to merge 37 commits into from

Conversation

wendevlin
Copy link
Contributor

@wendevlin wendevlin commented Jan 28, 2025

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@github-actions github-actions bot added the Supervisor Related to the supervisor panel label Jan 28, 2025
@wendevlin wendevlin force-pushed the backup-onboarding-core branch from 00f3362 to ecf861f Compare January 29, 2025 06:58
@wendevlin wendevlin force-pushed the backup-onboarding-core branch from 62c2406 to 474cfb2 Compare January 29, 2025 14:17
@wendevlin wendevlin marked this pull request as ready for review January 29, 2025 14:29
@wendevlin wendevlin added the Backend Change Required Requires a Backend Core Code Change label Jan 29, 2025
@silamon silamon removed the Backend Change Required Requires a Backend Core Code Change label Jan 29, 2025
@@ -154,7 +162,7 @@ export class DialogUploadBackup

this._uploading = true;
try {
await uploadBackup(this.hass!, file, agentIds);
await uploadBackup(file, agentIds, this.hass);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hass is optional right? Should be typed correctly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No why? backup panel will always have hass right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend merged The backend PR for this frontend PR has been merged cla-signed Supervisor Related to the supervisor panel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants