Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard accessibility for automation-action-row (convert M2->M3) #24121

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Feb 7, 2025

Proposed change

Fix some accessibility issues in the automation editor. Starting with the action row only for proof of concept. (save triggers/conditions for later)

This PR fixes:

  1. The overflow menu seems it cannot currently even be opened with the keyboard. Focusing the button menu and pressing any keystroke just expands/collapses the expansion panel.
  2. If you could get it open, you still couldn't navigate past the disabled items (see Can't get past disabled overflow menu items with keyboard #20002). This is fixed by converting to ha-md-button-menu, which does not have this bug.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant