Update docker-compose.yml to change obsolete code #20 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the docker-compose.yml file to enhance network stability, prevent conflicts, and ensure proper container startup sequencing. The following changes and fixes have been implemented:
Updated #20
Removed version: '3.8' as it is no longer needed in recent Docker Compose versions.
Renamed host network to custom_network to avoid conflicts with the host network.
Implemented a custom bridge network to ensure IPv4 addressing works as expected.
Added a health check for Dicomhawk to confirm it is fully ready before the logserver starts, preventing issues caused by dependent services starting too soon.
Testing
Verified that docker compose up --build runs successfully without network conflicts.
I assure you that the dicomhawk initializes properly before logserver starts.
Checked network configurations to confirm stable communication between services.
Contributor :
Muhammad Faizan Sajid (PR author and contributor)
Reviewer :
@gtheodoridis