add optional timeout #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents hanging threads due to network issues.
| @@ -30,16 +30,31 @@ | |||
| u'pcls_fix': u'PreviousClosePrice' | |||
| } | |||
|
|
|||
| DEFAULT_TIMEOUT = None | |||
There was a problem hiding this comment.
Please set a number here for a default value
There was a problem hiding this comment.
Are you sure you want that? It will make this change non-backwards compatible.
Meaning that some clients (who are on bad networks perhaps?) may start timing out.
So, should I set this default value to something ridiculous, like 30 seconds?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents hanging threads due to network issues.