-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve type inference issue with u32::MAX conversion #244
Conversation
@hoodie Could we get a patch release with this fix out? My builds are breaking because of this. FWIW, I was able to also solve this using an explicit
|
Could you help me with a PR here? The first fix seems to not pass clippy. |
You don't need to put the name of the crate in the commit message scope. |
Can you please check the latest one? |
Could you squash this once more? The first commits are failing the checks. Sorry I can only interact on my phone today. |
I'll be back on a computer tomorrow night. I'll just finish this then. Thanks for noticing and fixing this. |
I'm going to send it one more time today when I'm free... I'm on my phone too :3 |
Explicitly cast `as_millis()` result to `u128` to avoid type inference error. This fixes compilation failure in `notify-rust` related to `PartialOrd` trait ambiguity when comparing `duration.as_millis()` with `u32::MAX.into()`. Refs: rust-lang/rust#E0283
Explicitly cast `as_millis()` result to `u128` to avoid type inference error. This fixes compilation failure in `notify-rust` related to `PartialOrd` trait ambiguity when comparing `duration.as_millis()` with `u32::MAX.into()`. Refs: rust-lang/rust#E0283
Thank you for your help. I'll try to release this soon |
Explicitly cast
as_millis()
result tou128
to avoid type inference error. This fixes compilation failure innotify-rust
related toPartialOrd
trait ambiguity when comparingduration.as_millis()
withu32::MAX.into()
.Refs: rust-lang/rust#E0283