-
Notifications
You must be signed in to change notification settings - Fork 15
chore: Azure SB Emulator for testing & local development #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: lock
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -8,6 +8,9 @@ import ( | |||
) | |||
|
|||
type AzureServiceBusConfig struct { | |||
// Using AzureSB with ConnectionString will skip infra management | |||
ConnectionString string `yaml:"connection_string" env:"AZURE_SERVICEBUS_CONNECTION_STRING" desc:"Azure Service Bus connection string" required:"N"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to call attention to this config a bit. This should be "dev-only" config as it's not recommended in production.
Outpost is responsible for managing its own mq infra. Using Azure connection string will bypass this mechanism. This could work for now if the operator is comfortable managing their own resources, and most importantly follow along Outpost development to make changes if necessary.
Ideally, I'd like to hide this from config away from users if possible. I haven't explored the config docgen much, do you have a suggestion here? @leggetter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexluong - we could add another attribute: ...required:"N" hidden: true
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that should work!
@@ -0,0 +1,82 @@ | |||
// Azure Service Bus Testing Infrastructure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also calling this out as a significant limitation of Azure ServiceBus emulator
# Reserve 5672 for AzureSB Emulator which doens't support custom ports. | ||
# We may not need to expose 5672 at all if we run the full local dev env with Docker Compose. | ||
# - 5673:5672 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another quirk. Basically AzureSB emulator requires port 5672 to work, so it's stealing that port from our RabbitMQ deps
No description provided.