Skip to content

fix: regex pattern for webhook URL validation #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexluong merged 3 commits into from
Jan 14, 2026
Merged

fix: regex pattern for webhook URL validation #619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0d978b
Fix regex pattern for webhook URL validation
voytech-net Jan 7, 2026
addd4b6
fix: apply URL percent-encoding fix to all providers
alexluong Jan 13, 2026
fb9b769
test: add URL pattern validation tests
alexluong Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/destregistry/metadata/providers/aws_kinesis/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"label": "Endpoint",
"description": "Custom endpoint URL for AWS Kinesis (optional, for testing or VPC endpoints)",
"required": false,
"pattern": "^https?:\\/\\/[\\w\\-]+(?:\\.[\\w\\-]+)*(?::\\d{1,5})?(?:\\/[\\w\\-\\/\\.~:?#\\[\\]@!$&'\\(\\)*+,;=]*)?$"
"pattern": "^https?:\\/\\/[\\w\\-]+(?:\\.[\\w\\-]+)*(?::\\d{1,5})?(?:\\/[\\w\\-\\/\\.~:%?#\\[\\]@!$&'\\(\\)*+,;=]*)?$"
},
{
"key": "partition_key_template",
Expand Down
2 changes: 1 addition & 1 deletion internal/destregistry/metadata/providers/aws_sqs/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"label": "Queue URL",
"description": "The URL of your AWS SQS queue",
"required": true,
"pattern": "^https?:\\/\\/[\\w\\-]+(?:\\.[\\w\\-]+)*(?::\\d{1,5})?(?:\\/[\\w\\-\\/\\.~:?#\\[\\]@!$&'\\(\\)*+,;=]*)?$"
"pattern": "^https?:\\/\\/[\\w\\-]+(?:\\.[\\w\\-]+)*(?::\\d{1,5})?(?:\\/[\\w\\-\\/\\.~:%?#\\[\\]@!$&'\\(\\)*+,;=]*)?$"
}
],
"credential_fields": [
Expand Down
2 changes: 1 addition & 1 deletion internal/destregistry/metadata/providers/webhook/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"label": "Webhook URL",
"description": "The URL to send webhook events to via HTTP POST",
"required": true,
"pattern": "^https?:\\/\\/[\\w\\-]+(?:\\.[\\w\\-]+)*(?::\\d{1,5})?(?:\\/[\\w\\-\\/\\.~:?#\\[\\]@!$&'\\(\\)*+,;=]*)?$"
"pattern": "^https?:\\/\\/[\\w\\-]+(?:\\.[\\w\\-]+)*(?::\\d{1,5})?(?:\\/[\\w\\-\\/\\.~:%?#\\[\\]@!$&'\\(\\)*+,;=]*)?$"
},
{
"key": "custom_headers",
Expand Down
2 changes: 1 addition & 1 deletion internal/destregistry/metadata/providers/webhook_standard/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"label": "Webhook URL",
"description": "The URL to send webhook events to via HTTP POST (Standard Webhooks compliant)",
"required": true,
"pattern": "^https?:\\/\\/[\\w\\-]+(?:\\.[\\w\\-]+)*(?::\\d{1,5})?(?:\\/[\\w\\-\\/\\.~:?#\\[\\]@!$&'\\(\\)*+,;=]*)?$"
"pattern": "^https?:\\/\\/[\\w\\-]+(?:\\.[\\w\\-]+)*(?::\\d{1,5})?(?:\\/[\\w\\-\\/\\.~:%?#\\[\\]@!$&'\\(\\)*+,;=]*)?$"
},
{
"key": "custom_headers",
Expand Down
45 changes: 45 additions & 0 deletions internal/destregistry/providers/destwebhook/destwebhook_validate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,51 @@ func TestWebhookDestination_Validate(t *testing.T) {
assert.Equal(t, "config.url", validationErr.Errors[0].Field)
assert.Equal(t, "pattern", validationErr.Errors[0].Type)
})

t.Run("should accept valid URLs", func(t *testing.T) {
t.Parallel()
validURLs := []string{
"https://example.com",
"https://example.com/path",
"https://example.com:8080/path",
"https://example.com/path?query=value",
"https://example.com/path#fragment",
"https://sub.example.com/path",
"http://localhost:3000/webhook",
// Percent-encoded URLs (Azure Logic Apps, etc.)
"https://example.com/path?param=%2Fencoded%2Fslash",
"https://example.com/path%2Fwith%2Fencoded",
"https://logic.azure.com/workflows/abc123/triggers/manual?api-version=2016&sp=%2Ftriggers%2Fmanual%2Frun",
}
for _, url := range validURLs {
t.Run(url, func(t *testing.T) {
t.Parallel()
dest := validDestination
dest.Config = map[string]string{"url": url}
assert.NoError(t, webhookDestination.Validate(context.Background(), &dest))
})
}
})

t.Run("should reject invalid URLs", func(t *testing.T) {
t.Parallel()
invalidURLs := []string{
"not-a-url",
"ftp://example.com",
"://missing-scheme.com",
"https://",
"",
}
for _, url := range invalidURLs {
t.Run(url, func(t *testing.T) {
t.Parallel()
dest := validDestination
dest.Config = map[string]string{"url": url}
err := webhookDestination.Validate(context.Background(), &dest)
assert.Error(t, err)
})
}
})
}

func TestWebhookDestination_ValidateSecrets(t *testing.T) {
Expand Down
Loading