fix: manual retry blocked by idempotency after first success#670
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexluong
changed the title
alexbouchardd
approved these changes
Feb 2, 2026
alexluong
force-pushed
the
fix-manual-retry
branch
from
be850f5 to
919c351
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Calling
POST /retryfor the same event+destination a second time silently does nothing. The delivery task starts processing but produces no delivery.This is a regression from #653: removing
DeliveryEvent.IDmade the manual retry idempotency key static (event_id:destination_id:manual). Once the first retry succeeds, the key is marked "processed" for 24h, silently blocking all subsequent retries.Solution
Add a
Noncefield toDeliveryTask, generated per manual retry request. The nonce is included in the idempotency key so separate/retrycalls get unique keys, while MQ redeliveries of the same message are still deduplicated.Other changes
Test plan
TestManualDelivery_DuplicateRetryTestRetry_DuplicateManualRetryExecutesBothdeliverymqtest suite passes