refactor: remove unused DestinationID from RetrieveEventRequest#679
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
After iterations of access patterns, the current version doesn't require DestinationID in this operation. Events are destination-agnostic - use ListAttempt with DestinationIDs filter for destination-scoped queries. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
RetrieveEvent now queries the events table directly instead of the attempts table. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
alexluong
force-pushed
the
logstore-retrieve-destinationid
branch
from
February 6, 2026 07:20
a3b9ec8 to
0027a76
Compare
…errors RetrieveEvent and RetrieveAttempt used Query + rows.Next() without checking rows.Err(), causing ClickHouse query errors to be silently treated as "not found" (404) instead of surfacing as errors (500). Switch to QueryRow which handles this correctly via sql.ErrNoRows. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
alexbouchardd
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After iterations of access patterns, the current version doesn't require DestinationID in this operation. Events are destination-agnostic - use ListAttempt with DestinationIDs filter for destination-scoped queries.