fix(spec): correct GET /events parameter indices in Python pagination overlay#694
Merged
Merged
Conversation
… overlay After destination_id was removed from GET /events, next/prev moved to indices 5 and 6. The overlay was still targeting 6 and 7, which broke Python SDK generation (Compile SDK step). Only Python uses this overlay. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Python SDK–only pagination overlay so it correctly renames the next/prev query parameters for GET /events after the OpenAPI parameter list changed in v0.13, unblocking Python SDK generation during the compile step.
Changes:
- Fix JSONPath targets for
GET /eventsparameter overrides to use indices[5]and[6](fornextandprev). - Update the inline comment documenting the expected parameter ordering for
GET /events.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After
destination_idwas removed from GET /events (v0.13), thenextandprevquery parameters moved to indices 5 and 6. The pagination-fixes overlay (used only by the Python SDK) was still targeting indices 6 and 7, which caused Python SDK generation to fail during the Compile SDK step.This change updates the overlay to target parameters 5 and 6 for GET /events so the Python SDK builds successfully.
Made with Cursor