fix(sdks): extract shared pagination config from Python-only overlay - #750
Merged
Conversation
The pagination cursor config (x-speakeasy-pagination) was bundled in the Python pagination fixes overlay, which is only applied to the Python SDK source. This meant Go and TS SDKs lost auto-pagination support after #744 split the sources. Extract the pagination config into a shared overlay applied to all three sources, keeping only the Python builtin name overrides (dir, next, prev) in the Python-specific overlay. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
Good spot, @alexluong 👍 |
leggetter
approved these changes
Mar 13, 2026
This was referenced Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pagination cursor config (
x-speakeasy-pagination) was bundled inside the Python-specific overlay, which only applies to the Python SDK source. After #744 split the Speakeasy sources by language, Go and TS SDKs lost auto-pagination support.pagination-config-overlay.yamlapplied to all three sourcesdir→direction,next→next_cursor,prev→prev_cursor) inpython-pagination-fixes-overlay.yamlspeakeasy overlay validateTest plan
speakeasy overlay validatepasses for both overlaysspeakeasy overlay applyconfirms 4 pagination configs applied🤖 Generated with Claude Code