fix: restore delivered_events metric recording#771
Merged
Conversation
EventDelivered() was accidentally dropped in the DeliveryEvent → DeliveryTask refactor (PR #653). The old code derived delivery success/failure from the model, but DeliveryTask no longer carries result data. Add RecordDeliveryResult on DeliverSpan so doHandle can signal the outcome, and emit the metric in End(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Dashboard queried status="ok" but the code emits status="success" for delivered_events metric. Also update otel-collector telemetry config for newer collector versions (address → readers). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexbouchardd
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
outpost.delivered_eventsOTEL metric that was accidentally dropped during theDeliveryEvent→DeliveryTaskrefactor in chore: remove delivery event concept #653RecordDeliveryResult(ok bool)onDeliverSpansodoHandlecan signal delivery outcome, emittingEventDeliveredinEnd()status="ok"instead ofstatus="success"for delivered events panelsaddress→readers)emetrics.New()error is safely ignoredTest plan
main:delivered_eventsmetric is absent (bug confirmed)delivered_eventsmetric is present with correctstatusandtypedimensionsgo build ./...passesgo test ./internal/deliverymq/...passes🤖 Generated with Claude Code