Skip to content

fix: return SuccessResponse from DELETE /destinations - #798

Merged
alexluong merged 1 commit into
mainfrom
fix/705-delete-destination-response
Mar 25, 2026
Merged

fix: return SuccessResponse from DELETE /destinations#798
alexluong merged 1 commit into
mainfrom
fix/705-delete-destination-response

Conversation

@alexluong

Copy link
Copy Markdown
Collaborator

Summary

  • Change DELETE /tenants/{tid}/destinations/{did} to return { "success": true } instead of the full destination object
  • Aligns with DELETE /tenants/{tid} behavior and the existing OpenAPI spec

Closes #705

Test plan

  • Updated unit test to assert response body is { "success": true }
  • All existing delete destination tests pass

🤖 Generated with Claude Code

Change the destination delete handler to return `{ "success": true }`
instead of the full destination object, matching the tenant delete
behavior and the OpenAPI spec.

Closes #705

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Mar 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
outpost-docs Ready Ready Preview, Comment Mar 25, 2026 9:35pm
outpost-website Ready Ready Preview, Comment Mar 25, 2026 9:35pm

Request Review

@vercel
vercel Bot temporarily deployed to Preview – outpost-docs March 25, 2026 21:35 Inactive
@vercel
vercel Bot temporarily deployed to Preview – outpost-website March 25, 2026 21:35 Inactive
@alexluong
alexluong merged commit bcc9041 into main Mar 25, 2026
5 checks passed
@alexluong
alexluong deleted the fix/705-delete-destination-response branch March 25, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DELETE /destinations response inconsistent with DELETE /tenants

2 participants