fix(spec-sdk-tests): remove vestigial @hookdeck/outpost-sdk alias#971
Merged
Conversation
The `file:` dep and tsconfig `paths`/`include` for `@hookdeck/outpost-sdk` pointed three levels up (`../../../sdks/...`), resolving outside the repo — wrong since the suite was created. The alias was never imported anywhere; every test uses direct relative paths to `dist/commonjs`. Drop the dead, misleading config to match how the tests actually wire the SDK. Closes #928 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
alexbouchardd
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #928.
What
Removes the
@hookdeck/outpost-sdkpackage alias fromspec-sdk-tests:package.json— thefile:../../../sdks/outpost-typescriptdependencytsconfig.json— the matchingpathsentries and the SDKincludeWhy
The alias paths pointed
../../../(three levels up), resolving outside the repo — wrong since the suite was first added. It never surfaced because the alias was never imported anywhere; every test, util, and factory imports the SDK via direct relative path (../../sdks/outpost-typescript/dist/commonjs).npm installdidn't fail because modern npm doesn't verifyfile:targets at install time.Chose option 2 from the issue (remove the alias) over option 1 (fix the paths): it matches how the suite actually wires the SDK today, and is a zero-risk deletion of dead config. Switching the suite to package-name imports (option 1) would be a larger change worth its own issue.
Verification
Run against a live local Outpost stack (
make up):npm install— clean (no longer references the badfile:path)npm run type-check(tsc --noEmit) — clean (removed alias/include weren't needed)npm test— 153 passing, 15 pending🤖 Generated with Claude Code