Sly1: Address Fuzzer concerns, Client QoL update (Universal Tracker support with yamlless support)#14
Open
AmondoVagyok wants to merge 10 commits intohoppel16:mainfrom
Open
Sly1: Address Fuzzer concerns, Client QoL update (Universal Tracker support with yamlless support)#14AmondoVagyok wants to merge 10 commits intohoppel16:mainfrom
AmondoVagyok wants to merge 10 commits intohoppel16:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR add?
Raise OptionError where needed
This PR mainly aims to solve the concerns regarding fuzzer result. Now the apworld should throw an OptionError if the generation has more items than location and suggest options to the player to turn on.
Universal Tracker implementation
This allows the client to use Universal Tracker, allowing the use of the "Tracker" page directly from the client. This also supports yamlless tracking.
General client change
The client now show "Sly 1 client" and the version of the apworld instead of text client, it also shows the Universal Tracker version when applicable