[WIP] ISSUE-1340 Upgrade jackson and relevant dependencies (directly and indirectly)#1341
[WIP] ISSUE-1340 Upgrade jackson and relevant dependencies (directly and indirectly)#1341HeartSaVioR wants to merge 3 commits intohortonworks:masterfrom
Conversation
|
Since it touches various dependencies we may not feel safe to just rely on unit test. We may need to step back and not rush it... Which tests should we perform before merge this? If we feel safe to rely on system tests we need to merge so we have contradiction here. |
| <!-- Ideally we need to use official version of SR: wait for new release --> | ||
| <schema-registry.version>0.6.0.3.4.0.0-145</schema-registry.version> | ||
| <!-- This version should be changed to actual HDF-3.4.0.0-146 version when it is published --> | ||
| <schema-registry.version>0.6.1-SNAPSHOT-HDF-3.4.0.0-146-maybe</schema-registry.version> |
There was a problem hiding this comment.
Should be changed to 3.4.0.0-146 (or higher) or new official SR version.
There was a problem hiding this comment.
Agree to keep the HDF version until the new SR version is pushed.
arunmahadevan
left a comment
arunmahadevan
left a comment
There was a problem hiding this comment.
The changes looks good. For testing we need to rely on system tests. Maybe you can point your branch to canary and trigger a build + test (assuming that the streamline system tests run as a part of canary)
| <curator.version>2.11.0</curator.version> | ||
| <dropwizard.version>1.0.5</dropwizard.version> | ||
| <curator.version>4.0.1</curator.version> | ||
| <curator.test.version>2.12.0</curator.test.version> |
There was a problem hiding this comment.
is it ok to have different version just for test ?
There was a problem hiding this comment.
I picked it up from Registry project, but it doesn't look like needed for Streamline. Will remove.
…directly) This patch brings change of huge dependencies so should be tested thoughtfully. Change-Id: Ic02c92aeb302a79b68598f6e0e66f18165fd2b43
Change-Id: I924e9508aa70c0340785d2da9234d1769e7a7eb3
Change-Id: Ib16f1c70872ae6eed54649cefca5235f9fe2ce60
2 participants
This patch brings change of huge dependencies so should be tested thoughtfully.
The build passed with custom build of SR, and I'll upgrade once the version is available in HWX repo. After that we can check whether the build passes in Travis CI.
This closes #1340