Skip to content

Conversation

@JHeigle
Copy link

@JHeigle JHeigle commented May 15, 2023

Hey @hossein-zare, saw a potential small issue with the custom item value .replace() modifier for spaces. This update will allow users to customize the delimiter for the value saved when selecting a custom item and make sure that the delimiter is implemented in all space instances.

  • The value for the customItemValueDelimiter defaults to what was already in place (-).
  • .replace() was replaced (no pun intended) with .replaceAll().

Helps resolve issue #604.

Thank you for your feedback!

@jacklj
Copy link

jacklj commented Jul 10, 2023

This is great, thanks, could it be merged please?

@joshzeldin
Copy link

This is great and helps solve the issue I was having #604

I was looking into this same thing and was struggling to figure out why the space to dash replacement was necessary at all. Do you know what the purpose of the replacement is? For my use, I'd like to maintain the spaces in my items, but I'm not sure if this is going to break the library?

@JHeigle
Copy link
Author

JHeigle commented Oct 4, 2024

This is great and helps solve the issue I was having #604

I was looking into this same thing and was struggling to figure out why the space to dash replacement was necessary at all. Do you know what the purpose of the replacement is? For my use, I'd like to maintain the spaces in my items, but I'm not sure if this is going to break the library?

I don't have an exact answer regarding the original purpose of the replacement; however, from my testing, it does not appear to affect the behavior of the dropdown in any way other than intended. My main intention was to use spaces as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants