Support the Revision attribute, dropping PHP<8.3 support#22
Merged
Conversation
janlam7
commented
Jun 11, 2026
janlam7
commented
Contributor
- Adds the Revision attribute, deprecating the annotation
- Drops PHP<8.3 support
- Needs Support the Tracked attribute, dropping PHP<8.3 support entity-tracker-component#45
janlam7
force-pushed
the
attribute-support
branch
from
36074b1 to
438e8f0
Compare
phonixor
reviewed
Jun 17, 2026
| return $this->save($cached_item, true); | ||
| } | ||
|
|
||
| if (null !== $this->resolver->getRevisionAnnotation($em, $entity)) { |
There was a problem hiding this comment.
i think i would have moved this logic to the combined resolver so it can answer ones... but i guess it doesn't matter as we will remove the annotation variant soonish
phonixor
approved these changes
Jun 17, 2026
FlorisTurkenburg
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.