Repository navigation
chore: the SDK whose iOS core is core-ios 0.1.0's prebuilt XCFramework, and the CLI at 4eba9a1 - #6
Merged
Merged
Conversation
…k, and the CLI at 4eba9a1 [skip ci] Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
The build documentation still incorrectly describes iOS dependency pinning, and the PR lacks a closing issue reference linking the SDK and CLI updates to their intended issue.
2 open issues
What changed in this PR
Updates the Cordova demo’s SDK and CLI pins, bringing in the SDK that uses core-ios 0.1.0’s prebuilt XCFramework.
Changes:
- Pins the Cordova SDK to commit
087f83eand the CLI to4eba9a1. - Synchronizes npm lockfile URLs, integrity hashes, and the CLI package version.
| File | Description |
|---|---|
package.json |
Updates the SDK and CLI dependency pins. |
package-lock.json |
Records matching dependency resolutions and integrity hashes. |
Review effort: Balanced
| }, | ||
| "devDependencies": { | ||
| "@hotcodepush/cordova-code-push": "https://pkg.pr.new/hotcodepush-team/cordova-code-push/@hotcodepush/cordova-code-push@9e6d6777b5c3800fa1cf3ccb645b2e5b59290530", | ||
| "@hotcodepush/cordova-code-push": "https://pkg.pr.new/hotcodepush-team/cordova-code-push/@hotcodepush/cordova-code-push@087f83e5edbdd28eaac8bd9e8605c3aa11e11bc1", |
| }, | ||
| "devDependencies": { | ||
| "@hotcodepush/cordova-code-push": "https://pkg.pr.new/hotcodepush-team/cordova-code-push/@hotcodepush/cordova-code-push@9e6d6777b5c3800fa1cf3ccb645b2e5b59290530", | ||
| "@hotcodepush/cordova-code-push": "https://pkg.pr.new/hotcodepush-team/cordova-code-push/@hotcodepush/cordova-code-push@087f83e5edbdd28eaac8bd9e8605c3aa11e11bc1", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the SDK commit whose iOS core is core-ios 0.1.0's prebuilt XCFramework, and the CLI at 4eba9a1 (no Podfile pin,
HOTCODEPUSH_API_URL). Lockfiles updated withnpm install --package-lock-only; native lockfiles edited by hand where they named the old core pin, refreshed by the nextpod install/ package resolution. Committed with[skip ci]; CI is dispatched on the branch.🤖 Generated with Claude Code