fix: add pkgutil.extend_path to namespace package init#11
Merged
Conversation
- Fix hother/__init__.py to properly support namespace packages - Add pkgutil.extend_path() call required for multiple packages - Enables other packages in hother namespace to be imported
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
hothernamespace package to properly support multiple packages in the same namespace.Changes
src/hother/__init__.pyto includepkgutil.extend_path()callhother.cancelable,hother.streamblocks, andhother.reactive_agentto coexistTechnical Details
Without
pkgutil.extend_path(), only the last installed package in thehothernamespace is accessible. This causesModuleNotFoundErrorwhen trying to import other packages in the namespace.Before:
# Namespace package marker for hotherAfter:
Testing
Impact
This is a critical fix for the hother namespace package ecosystem. It enables proper installation of multiple hother-* packages.