Skip to content

Fixed: logic for fetching orders when showShippingOrders is enabled #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ymaheshwari1 wants to merge 1 commit into from
Closed

Fixed: logic for fetching orders when showShippingOrders is enabled #780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/store/order.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ export const useOrderStore = defineStore('order', {
pageIndex: params.viewIndex
} as any;

if (useProductStore().isProductStoreSettingEnabled('SHOW_SHIPPING_ORDERS')) {
if (useProductStore().isProductStoreSettingEnabled('showShippingOrders')) {

@gemini-code-assist gemini-code-assist Bot May 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of querying the setting with a hardcoded string key, you can use the existing isShowShippingOrdersEnabled getter defined in the productStore. This improves type safety and maintainability.

Suggested change
if (useProductStore().isProductStoreSettingEnabled('showShippingOrders')) {
if (useProductStore().isShowShippingOrdersEnabled) {

queryParams = {
shipmentMethodTypeId: 'STOREPICKUP',
shipmentMethodTypeId_op: 'equals',
Expand Down Expand Up @@ -499,7 +499,7 @@ export const useOrderStore = defineStore('order', {
pageIndex: params.viewIndex || 0
} as any

if (!useProductStore().isProductStoreSettingEnabled('SHOW_SHIPPING_ORDERS')) {
if (!useProductStore().isProductStoreSettingEnabled('showShippingOrders')) {

@gemini-code-assist gemini-code-assist Bot May 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of querying the setting with a hardcoded string key, you can use the existing isShowShippingOrdersEnabled getter defined in the productStore. This improves type safety and maintainability.

Suggested change
if (!useProductStore().isProductStoreSettingEnabled('showShippingOrders')) {
if (!useProductStore().isShowShippingOrdersEnabled) {

queryParams.shipmentMethodTypeIds = 'STOREPICKUP'
}

Expand Down Expand Up @@ -576,7 +576,7 @@ export const useOrderStore = defineStore('order', {
pageIndex: params.viewIndex || 0
} as any

if (!useProductStore().isProductStoreSettingEnabled('SHOW_SHIPPING_ORDERS')) {
if (!useProductStore().isProductStoreSettingEnabled('showShippingOrders')) {

@gemini-code-assist gemini-code-assist Bot May 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of querying the setting with a hardcoded string key, you can use the existing isShowShippingOrdersEnabled getter defined in the productStore. This improves type safety and maintainability.

Suggested change
if (!useProductStore().isProductStoreSettingEnabled('showShippingOrders')) {
if (!useProductStore().isShowShippingOrdersEnabled) {

queryParams.shipmentMethodTypeIds = 'STOREPICKUP'
}

Expand Down
Loading