Switching modal context behavior #97
Closed
+94
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: Fix conflict. Log cold boot visit redirects. Fix spacing. Rename `redirect` result case to `sameOriginRedirect`. Simplify check for successful status code in a HTTPURLResponse. Add missing session delegate function. Handle cross-origin redirect on cold boot visit. Treat cross-origin redirect url as external url. Add logging around cross-origin redirect code in Session. Group response validation in redirect handler. Handle cross origin redirect in navigator. Resolve redirect when visit request fails with non http status code. Implement redirect handler. Handle failed visit request with non http status code and forward it to the appropriate delegate. Update turbo.js to notify the native side of failed requests with non https status codes.
* main: Update iframe navigation comment for cold boot visit. Ignore cross-origin redirects that aren’t happening in the main frame. Rename `userAgentComponent` to `userAgent`. update name to `userAgentComponent` expose user agent get only test Fix URL in comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.