Trigger a turbo:before-add-element event when adding a new node #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coorasse
force-pushed
the
trigger-event-for-new-nodes
branch
from
0d94e70
to
8388a21
Compare
coorasse
force-pushed
the
trigger-event-for-new-nodes
branch
from
8388a21
to
1b165ad
Compare
coorasse
changed the title
|
I'd love to get a feedback on this one. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing some animations on our page, we realized that we had no access to an event before an element was added to the DOM.
With this PR I'd like an early feedback from maintainers if this is the right direction and I can continue.
In particular regarding the event name.
If I get your OK, I'll:
Let me know 🙏