Implement Preloader with Mutation Observer
#1206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all external calls to `preloadOnLoadLinksForView`. In its place, introduce a new `AttributeObserver` to monitor all elements within a scope that: * added the `[data-turbo-preload]` attribute * connected with the `[data-turbo-preload]` attribute * connected with children that have the `[data-turbo-preload]` attribute The details of this observation are abstracted into the `AttributeObserver`, which will notify its delegate whenever those conditions are met. The delegate is responsible for responding to those conditions. For example, the `Preloader` ensures that the element is an `<a>` element, and that the element matches the expectations of **its** own delegate (the `Session` instance).
seanpdoyle
force-pushed
the
attribute-observer
branch
from
bf2584f
to
93dd552
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all external calls to
preloadOnLoadLinksForView. In its place, introduce a newAttributeObserverto monitor all elements within a scope that:[data-turbo-preload]attribute[data-turbo-preload]attribute[data-turbo-preload]attributeThe details of this observation are abstracted into the
AttributeObserver, which will notify its delegate whenever those conditions are met. The delegate is responsible for responding to those conditions. For example, thePreloaderensures that the element is an<a>element, and that the element matches the expectations of its own delegate (theSessioninstance).