Skip to content

25000: Fixes combine trainees to update inactive features if any involved trainees had them #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
howsoRes merged 2 commits into from
Jan 28, 2026
Merged

25000: Fixes combine trainees to update inactive features if any involved trainees had them #750

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3685b4
25000: Combine trainees updates inactive features after combining if …
howsoRes Jan 28, 2026
1fb5ec6
typo
howsoRes Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions howso/hierarchy.amlg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,6 +887,7 @@
;else it's just the number of cases
(call !GetNumTrainingCases)
)
has_inactive_features (size !inactiveFeaturesMap)
))

;clear all query caches
Expand Down Expand Up @@ -970,6 +971,10 @@
(contained_entities subtrainee (query_exists !internalLabelSession))
)

(if (size (call_entity subtrainee "debug_label" (assoc label "!inactiveFeaturesMap")))
(assign (assoc has_inactive_features .true))
)

;move all sessions over from subtrainee to trainee
(map
(lambda
Expand Down Expand Up @@ -1007,8 +1012,10 @@
))
(call !UpdateRegionalMinSize (assoc dataset_size (call !GetNumTrainingCases) ))
(call !ClearCachedDataProperties)
(if !inactiveFeaturesMap
(assign_to_entities (assoc !inactiveFeaturesNeedCaching .true ))

;if this trainee or any of the subtrainees had inactive features, make sure they are recomputed here
(if has_inactive_features
(call !UpdateInactiveFeatures)
)

(accum_to_entities (assoc !dataMassChangeSinceLastAnalyze (- new_dataset_size pre_combine_dataset_size) ))
Expand Down
Loading