Skip to content

25004: Fixes bug with inactive features with a specified domain would not be synthed #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
howsoRes merged 1 commit into from
Jan 29, 2026
Merged

25004: Fixes bug with inactive features with a specified domain would not be synthed #752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions howso/synthesis.amlg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,10 +210,14 @@

;inactive features simply output the one inactive value
(if (contains_index !inactiveFeaturesMap feature)
;if inactive is a null, only skip it if nulls are allowed (allow_null is either .true or not specified)
(if (or
(!= (null) (get !inactiveFeaturesMap feature))
(!= .false (get feature_bounds_map [feature "allow_null"]))
;if inactive is a null, only skip it if the domain isn't explicitly specified and
;nulls are allowed (allow_null is either .true or not specified)
(if (and
(= 0 (size (get feature_bounds_map [feature "allowed"])))
(or
(!= (null) (get !inactiveFeaturesMap feature))
(!= .false (get feature_bounds_map [feature "allow_null"]))
)
)
(seq
(assign (assoc
Expand Down
Loading