Skip to content

Fixed bad variable in builder.py. #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 23, 2025
Merged

Fixed bad variable in builder.py. #857

merged 6 commits into from
May 23, 2025

Conversation

dmageeLANL
Copy link
Collaborator

Code review checklist:

  • Code is generally sensical and well commented
  • Variable/function names all telegraph their purpose and contents
  • Functions/classes have useful doc strings
  • Function arguments are typed
  • Added/modified unit tests to cover changes.
  • New features have documentation added to the docs.
  • New features and backwards compatibility breaks are noted in the RELEASE.md

@dmageeLANL dmageeLANL requested a review from hwikle-lanl May 13, 2025 18:30
hwikle-lanl
hwikle-lanl previously approved these changes May 13, 2025
View reviewed changes
@hwikle-lanl
Roll back style tests to Python 3.9 (#858)
7ad37e9 
* Roll back style tests to Python 3.10

* Update unittests.yml
hwikle-lanl
hwikle-lanl previously approved these changes May 13, 2025
View reviewed changes
@hwikle-lanl hwikle-lanl merged commit b79a289 into develop May 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwikle-lanl hwikle-lanl hwikle-lanl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmageeLANL @hwikle-lanl