Skip to content

[feat] Support boxed math reward #6284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 29, 2025
Merged

[feat] Support boxed math reward #6284

merged 7 commits into from
Apr 29, 2025

Conversation

YeAnbang
Copy link
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs
  • I have installed pre-commit: pip install pre-commit && pre-commit install

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

Copy link
Member

@TongLi3701 TongLi3701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anbang.

One minor comment.

@TongLi3701
Copy link
Member

Please also address conflict first.

@YeAnbang YeAnbang changed the title [feat] Support boxed math reward [feat] Support boxed math reward; Fix pp state dict syncing Apr 29, 2025
@YeAnbang YeAnbang changed the title [feat] Support boxed math reward; Fix pp state dict syncing [feat] Support boxed math reward Apr 29, 2025
@YeAnbang YeAnbang requested a review from TongLi3701 April 29, 2025 08:25
@TongLi3701 TongLi3701 marked this pull request as ready for review April 29, 2025 08:46
@TongLi3701 TongLi3701 requested a review from a team as a code owner April 29, 2025 08:46
@TongLi3701 TongLi3701 merged commit 14f237c into grpo-latest Apr 29, 2025
3 checks passed
@YeAnbang YeAnbang deleted the grpo-boxed-dev branch April 29, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants