Refactor GSGUIUtilities class>>windowChild: to only return the child

hpi-swa · Jan 18, 2025 · ab08dc0 · ab08dc0
1 parent f9e9125
commit ab08dc0
Show file tree

Hide file tree

Showing 17 changed files with 19 additions and 21 deletions.
diff --git a/src/GitS-Core.package/GSAssetBrowser.class/instance/buildWindow..st b/src/GitS-Core.package/GSAssetBrowser.class/instance/buildWindow..st
@@ -2,6 +2,6 @@ toolbuilder
 buildWindow: builder
 	^ builder pluggableWindowSpec new
 		model: self;
-		children: (GSGUIUtilities windowChild: (self buildLayout: builder));
+		children: {GSGUIUtilities windowChild: (self buildLayout: builder)};
 		label: 'Git Asset Browser';
 		yourself
diff --git a/src/GitS-Core.package/GSAssetBrowser.class/methodProperties.json b/src/GitS-Core.package/GSAssetBrowser.class/methodProperties.json
@@ -37,7 +37,7 @@
 		"buildProjectList:" : "mad 10/9/2024 16:01",
 		"buildRemoveButton:" : "mad 12/21/2024 22:09",
 		"buildSelectedAssetName:" : "mad 12/21/2024 23:31",
-		"buildWindow:" : "mad 10/9/2024 16:01",
+		"buildWindow:" : "mad 1/18/2025 16:12",
 		"buildWith:" : "mad 9/20/2023 15:09",
 		"buildWorkspace:" : "mad 10/9/2024 16:01",
 		"chooseCompatibleMapper:" : "mad 10/9/2024 16:01",

diff --git a/src/GitS-Core.package/GSBrowser.class/instance/buildWindow..st b/src/GitS-Core.package/GSBrowser.class/instance/buildWindow..st
@@ -3,5 +3,5 @@ buildWindow: builder
 	^ builder pluggableWindowSpec new
 		model: self;
 		label: #windowTitle;
-		children: (GSGUIUtilities windowChild: (self buildLayout: builder));
+		children: {GSGUIUtilities windowChild: (self buildLayout: builder)};
 		yourself
diff --git a/src/GitS-Core.package/GSBrowser.class/methodProperties.json b/src/GitS-Core.package/GSBrowser.class/methodProperties.json
@@ -53,7 +53,7 @@
 		"buildRefsButtons:" : "mad 12/23/2024 20:02",
 		"buildRefsPanel:" : "mad 12/16/2024 20:36",
 		"buildUpperLayout:" : "mad 10/9/2024 16:01",
-		"buildWindow:" : "mad 10/9/2024 16:01",
+		"buildWindow:" : "mad 1/18/2025 16:25",
 		"buildWith:" : "mad 9/1/2023 14:44",
 		"close" : "mad 12/21/2024 18:25",
 		"commitList" : "mad 12/22/2024 00:12",

diff --git a/src/GitS-Core.package/GSChangesDialog.class/instance/buildWindow..st b/src/GitS-Core.package/GSChangesDialog.class/instance/buildWindow..st
@@ -3,5 +3,5 @@ buildWindow: builder
 	^ builder pluggableWindowSpec new
 		model: self;
 		label: #windowTitle;
-		children: (GSGUIUtilities windowChild: (self buildLayout: builder));
+		children: {GSGUIUtilities windowChild: (self buildLayout: builder)};
 		yourself
diff --git a/src/GitS-Core.package/GSChangesDialog.class/methodProperties.json b/src/GitS-Core.package/GSChangesDialog.class/methodProperties.json
@@ -13,7 +13,7 @@
 		"buildLayout:" : "mad 10/9/2024 16:01",
 		"buildMainLayout:" : "mad 9/15/2023 12:34",
 		"buildNothingSelected:" : "mad 10/9/2024 16:01",
-		"buildWindow:" : "mad 10/9/2024 16:01",
+		"buildWindow:" : "mad 1/18/2025 16:13",
 		"buildWith:" : "mad 9/2/2023 18:05",
 		"buttons" : "mad 9/15/2023 12:59",
 		"buttons:" : "mad 9/15/2023 13:03",

diff --git a/src/GitS-Core.package/GSCodePackageBrowser.class/instance/buildWindow..st b/src/GitS-Core.package/GSCodePackageBrowser.class/instance/buildWindow..st
@@ -2,6 +2,6 @@ toolbuilder
 buildWindow: builder
 	^ builder pluggableWindowSpec new
 		model: self;
-		children: (GSGUIUtilities windowChild: (self buildLayout: builder));
+		children: {GSGUIUtilities windowChild: (self buildLayout: builder)};
 		label: 'Package Browser';
 		yourself
diff --git a/src/GitS-Core.package/GSCodePackageBrowser.class/methodProperties.json b/src/GitS-Core.package/GSCodePackageBrowser.class/methodProperties.json
@@ -17,7 +17,7 @@
 		"buildMappedPackageList:" : "mad 12/21/2024 23:34",
 		"buildRemovePackageButton:" : "mad 12/21/2024 22:15",
 		"buildUnmappedPackageList:" : "mad 12/21/2024 23:34",
-		"buildWindow:" : "mad 10/9/2024 16:01",
+		"buildWindow:" : "mad 1/18/2025 16:13",
 		"buildWith:" : "mad 9/19/2023 15:46",
 		"categoriesChanged" : "mad 11/27/2023 11:50",
 		"categoriesPlusPrefixes" : "mad 11/27/2023 11:40",

diff --git a/src/GitS-Core.package/GSGUIUtilities.class/class/windowChild..st b/src/GitS-Core.package/GSGUIUtilities.class/class/windowChild..st
@@ -1,5 +1,5 @@
 toolbuilder
 windowChild: aSpec
-	^ {aSpec
+	^ aSpec
 		frame: LayoutFrame fullFrame;
-		yourself}
+		yourself
diff --git a/src/GitS-Core.package/GSGUIUtilities.class/methodProperties.json b/src/GitS-Core.package/GSGUIUtilities.class/methodProperties.json
@@ -15,6 +15,6 @@
 		"children:" : "mad 9/14/2023 14:11",
 		"displayStatus:during:" : "mad 10/2/2024 20:47",
 		"putSpecs:on:" : "mad 9/14/2023 14:33",
-		"windowChild:" : "mad 9/15/2023 16:22" },
+		"windowChild:" : "mad 1/18/2025 16:12" },
 	"instance" : {
 		 } }
diff --git a/src/GitS-Core.package/GSRebase.class/instance/buildWindow..st b/src/GitS-Core.package/GSRebase.class/instance/buildWindow..st
@@ -3,5 +3,5 @@ buildWindow: builder
 	^ builder pluggableWindowSpec new
 		model: self;
 		label: #windowTitle;
-		children: (GSGUIUtilities windowChild: (self buildLayout: builder));
+		children: {GSGUIUtilities windowChild: (self buildLayout: builder)};
 		yourself
diff --git a/src/GitS-Core.package/GSRebase.class/methodProperties.json b/src/GitS-Core.package/GSRebase.class/methodProperties.json
@@ -20,7 +20,7 @@
 		"buildMainLayout:" : "mad 4/4/2024 17:18",
 		"buildOperations:" : "mad 12/21/2024 22:19",
 		"buildRunButton:" : "mad 12/21/2024 22:09",
-		"buildWindow:" : "mad 10/9/2024 16:01",
+		"buildWindow:" : "mad 1/18/2025 16:13",
 		"buildWith:" : "mad 12/5/2023 21:17",
 		"canAbort" : "mad 4/7/2024 17:51",
 		"close" : "mad 4/7/2024 15:51",

diff --git a/src/GitS-Core.package/GSRemoteDialog.class/instance/buildDialogWith..st b/src/GitS-Core.package/GSRemoteDialog.class/instance/buildDialogWith..st
@@ -3,6 +3,6 @@ buildDialogWith: builder
 	^ builder pluggableDialogSpec new
 		model: self;
 		title: self title;
-		children: (self buildLayout: builder);
+		children: {GSGUIUtilities windowChild: (self buildLayout: builder)};
 		buttons: (self buildButtons: builder);
 		yourself
diff --git a/src/GitS-Core.package/GSRemoteDialog.class/instance/buildLayout..st b/src/GitS-Core.package/GSRemoteDialog.class/instance/buildLayout..st
@@ -1,5 +1,3 @@
 toolbuilder
 buildLayout: builder
-	^ {(self buildInputsPanel: builder)
-			frame: LayoutFrame fullFrame;
-			yourself}
+	^ self buildInputsPanel: builder
diff --git a/src/GitS-Core.package/GSRemoteDialog.class/methodProperties.json b/src/GitS-Core.package/GSRemoteDialog.class/methodProperties.json
@@ -10,9 +10,9 @@
 		"accepted:" : "mad 9/21/2023 18:15",
 		"buildButtons:" : "mad 9/21/2023 17:47",
 		"buildCancelButton:" : "mad 9/21/2023 18:16",
-		"buildDialogWith:" : "mad 9/21/2023 18:18",
+		"buildDialogWith:" : "mad 1/18/2025 16:14",
 		"buildInputsPanel:" : "mad 10/9/2024 16:01",
-		"buildLayout:" : "mad 9/21/2023 18:18",
+		"buildLayout:" : "mad 1/18/2025 16:14",
 		"buildOkButton:" : "mad 9/21/2023 17:47",
 		"buildRemoteNameInput:" : "mad 9/21/2023 18:20",
 		"buildRemoteUrlInput:" : "mad 11/10/2024 18:53",

diff --git a/src/GitS-Core.package/GSRemotesBrowser.class/instance/buildWindow..st b/src/GitS-Core.package/GSRemotesBrowser.class/instance/buildWindow..st
@@ -2,6 +2,6 @@ toolbuilder
 buildWindow: builder
 	^ builder pluggableWindowSpec new
 		model: self;
-		children: (GSGUIUtilities windowChild: (self buildLayout: builder));
+		children: {GSGUIUtilities windowChild: (self buildLayout: builder)};
 		label: #windowTitle;
 		yourself
diff --git a/src/GitS-Core.package/GSRemotesBrowser.class/methodProperties.json b/src/GitS-Core.package/GSRemotesBrowser.class/methodProperties.json
@@ -14,7 +14,7 @@
 		"buildLayout:" : "mad 10/9/2024 16:01",
 		"buildRemoteList:" : "mad 12/21/2024 22:09",
 		"buildRemoveRemoteButton:" : "mad 12/21/2024 22:09",
-		"buildWindow:" : "mad 10/9/2024 16:01",
+		"buildWindow:" : "mad 1/18/2025 16:16",
 		"buildWith:" : "mad 9/21/2023 17:02",
 		"hasSelectedRemote" : "mad 9/21/2023 18:06",
 		"open" : "mad 9/21/2023 17:08",