Repository navigation
test(direct-native): retain pending seals across bounded restart replay - #305
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent-decided, owner may revisit (2026-10-11): add a native public-room controller regression for a retained owner seal over 160 frames. Through real RoomSession and private temp stores, a joined reader remains fenced across reopen with incomplete messages and exact operation retries; out-of-order bounded catch-up and another reopen cannot leap a missing frame. A bad-signature frame has no durable effect; its valid exact retry plus bounded reconciliations reaches the exact seal, and final reopen retains signed terminal and local operation bytes. No wire or production API changes. Handoff and local evidence recorded in kb/plans/valhalla-promotion-gates.md.
Local Rust 1.98.1, locked: focused exact test (1/1);
cargo test -p vhalla-direct-native(69 lib, 5 integration); strict package Clippy all targets/features; fmt check; staged diff check. Cargo Git dependencies fetched withCARGO_NET_GIT_FETCH_WITH_CLI=trueafter native libgit TLS failed. Await exact-headRequiredand post-merge mainRequired; this does not qualify physical crash, independent machine, WASM, network availability, Railway, or release readiness.