Actually stream the data#31
Merged
Merged
Conversation
…inActor.run` is blocking
Contributor
Author
|
I don't think I've fully fixed this yet :/ |
Collaborator
|
Thanks for digging into this, @nathanborror! I recall this working as intended in a previous release, so maybe this was a regression from #13. It could also be a bug in the upstream EventStream package that we use to process SSEs. |
Contributor
Author
|
I think the main issue is |
Collaborator
Oh yeah, that's exactly the problem. Sorry about that! |
mattt
reviewed
Nov 13, 2025
mattt
force-pushed
the
nathanborror/fix-streaming
branch
from
a965626 to
3be3707
Compare
Collaborator
|
Thanks again for your help with this, @nathanborror! I just tested this out locally, and responses appear to be streaming as expected. |
Collaborator
|
This is now available in 0.4.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where data that is supposed to be streaming in is stalled until the stream has completed.