Fix crash on type cast on streaming with structured output#33
Closed
adityadaniel wants to merge 1 commit into
Closed
Conversation
Author
|
Seems like the crash still happening on example project while it passed the tests. Looking at it right now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mattt! 👋
Thanks again for your work on this PR. I’m really excited about getting structured generation with streaming fully working.
I’ve been exploring the implementation that seems to work so far. All tests are passing locally, but I’d love your feedback on the details of the implementation and whether there’s anything you think should be adjusted or improved.
Looking forward to hearing your thoughts!