-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
From Chunks to Blocks Blog Post #2659
Conversation
@pcuenca could you check this to make sure I've done my due diligence with metadata/folder structure? Thank you!! (Also, if you're interested in reading it, I'll always take feedback ❤️ 😄 ) |
@rajatarya I updated the intro and title to be a bit more in line with what you had discussed in Slack. Would love your feedback! Planning on publishing this tomorrow morning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! 🔥
Co-authored-by: Pedro Cuenca <[email protected]>
Markdown and grammar catches Co-authored-by: Pedro Cuenca <[email protected]>
Like the changes and pulling up the benefit callout into the intro paragraphs. Reads smoothly, looks good, let's go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, like the tone and flow of the post.
Congratulations! You've made it this far! Once merged, the article will appear at https://huggingface.co/blog. Official articles
require additional reviews. Alternatively, you can write a community article following the process here.
Preparing the Article
You're not quite done yet, though. Please make sure to follow this process (as documented here):
md
file. You can also specifyguest
ororg
for the authors.Here is an example of a complete PR: #2382
Getting a Review
Please make sure to get a review from someone on your team or a co-author.
Once this is done and once all the steps above are completed, you should be able to merge.
There is no need for additional reviews if you and your co-authors are happy and meet all of the above.
Feel free to add @pcuenca as a reviewer if you want a final check. Keep in mind he'll be biased toward light reviews
(e.g., check for proper metadata) rather than content reviews unless explicitly asked.