Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fireworks-ai inference support 🔥 #2677

Merged
merged 19 commits into from
Feb 14, 2025
Merged

Fireworks-ai inference support 🔥 #2677

merged 19 commits into from
Feb 14, 2025

Conversation

julien-c
Copy link
Member

No description provided.

fireworks-ai.md Outdated Show resolved Hide resolved
fireworks-ai.md Outdated Show resolved Hide resolved
fireworks-ai.md Outdated Show resolved Hide resolved
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, reads well!

fireworks-ai.md Outdated Show resolved Hide resolved
fireworks-ai.md Outdated Show resolved Hide resolved
fireworks-ai.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the TODO

Copy link
Collaborator

@burtenshaw burtenshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Just some nits, contributed a http snippet, and proposed a pro subs CTA.

fireworks-ai.md Outdated Show resolved Hide resolved
fireworks-ai.md Outdated Show resolved Hide resolved
fireworks-ai.md Show resolved Hide resolved
fireworks-ai.md Show resolved Hide resolved
fireworks-ai.md Show resolved Hide resolved
fireworks-ai.md Outdated Show resolved Hide resolved
fireworks-ai.md Show resolved Hide resolved
Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LETS GOOOO!

@pcuenca
Copy link
Member

pcuenca commented Feb 14, 2025

pro subs CTA

Great idea!

@julien-c
Copy link
Member Author

thank you'all for the help, merging now!

@julien-c julien-c merged commit 3c00687 into main Feb 14, 2025
1 check passed
@julien-c julien-c deleted the fireworks-ai branch February 14, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants