[modular] add tests for qwen modular #12585

sayakpaul · 2025-11-04T04:37:03Z

What does this PR do?

Some things came up with the tests that needed fixing. But LMK if you would like me to revert them.

Will propagate the changes from #12579 once it's merged.

sayakpaul · 2025-11-04T04:37:32Z

src/diffusers/modular_pipelines/qwenimage/before_denoise.py

    @property
    def inputs(self) -> List[InputParam]:
        return [
+            InputParam("latents"),


Similar to how it's done in the other pipelines.

sayakpaul · 2025-11-04T04:38:47Z

src/diffusers/modular_pipelines/qwenimage/before_denoise.py

                )
            ]
-            * block_state.batch_size
+            for _ in range(block_state.batch_size)


We have two options:

Either this

Or how it's done in edit:

diffusers/src/diffusers/pipelines/qwenimage/pipeline_qwenimage_edit.py

Lines 752 to 757 in 325a950

img_shapes = [

[

(1, height // self.vae_scale_factor // 2, width // self.vae_scale_factor // 2),

(1, calculated_height // self.vae_scale_factor // 2, calculated_width // self.vae_scale_factor // 2),

]

] * batch_size

Regardless, the current implementation isn't exactly the same as how the standard pipeline implements it and would break for the batched input tests we have.

sayakpaul · 2025-11-04T04:39:57Z

src/diffusers/modular_pipelines/qwenimage/decoders.py

        block_state = self.get_block_state(state)

        # YiYi Notes: remove support for output_type = "latents', we can just skip decode/encode step in modular
+        vae_scale_factor = 2 ** len(components.vae.temperal_downsample)


Keeping vae_scale_factor fixed to 8, for example, would break the tests as we use a smaller VAE.

sayakpaul · 2025-11-04T04:40:18Z

src/diffusers/modular_pipelines/qwenimage/encoders.py

+        block_state.negative_prompt_embeds = None
+        block_state.negative_prompt_embeds_mask = None


Otherwise, no CFG settings would break.

sayakpaul · 2025-11-04T04:40:53Z

tests/modular_pipelines/qwen/test_modular_pipeline_qwenimage.py

+    @pytest.mark.xfail(condition=True, reason="Batch of multiple images needs to be revisited", strict=True)
+    def test_num_images_per_prompt(self):
+        super().test_num_images_per_prompt()
+
+    @pytest.mark.xfail(condition=True, reason="Batch of multiple images needs to be revisited", strict=True)
+    def test_inference_batch_consistent():
+        super().test_inference_batch_consistent()
+
+    @pytest.mark.xfail(condition=True, reason="Batch of multiple images needs to be revisited", strict=True)
+    def test_inference_batch_single_identical():
+        super().test_inference_batch_single_identical()


These are skipped in the standard pipeline tests, too.

HuggingFaceDocBuilderDev · 2025-11-04T04:52:44Z

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

sayakpaul · 2025-11-04T08:29:41Z

With transformers latest the modular tests are failing in this PR. Checking.

Update: Checking with the transformers team. Internal link:
https://huggingface.slack.com/archives/C014N4749J9/p1762245891630079

All of those tests work with transformers 4.57.1

DN6

Just comments on aligning with new testing structure.

DN6 · 2025-11-04T12:51:07Z

tests/modular_pipelines/qwen/test_modular_pipeline_qwenimage.py

+from ..test_modular_pipelines_common import ModularPipelineTesterMixin
+
+
+class QwenImageModularTests:


Suggested change

class QwenImageModularTests:

class QwenImageModularTesterMixin:

DN6 · 2025-11-04T12:51:37Z

tests/modular_pipelines/qwen/test_modular_pipeline_qwenimage.py

+    pipeline_class = QwenImageModularPipeline
+    pipeline_blocks_class = QwenImageAutoBlocks
+    repo = "hf-internal-testing/tiny-qwenimage-modular"
+
+    params = frozenset(["prompt", "height", "width", "negative_prompt", "attention_kwargs", "image", "mask_image"])
+    batch_params = frozenset(["prompt", "negative_prompt", "image", "mask_image"])


Let's move these into the actual test object e.g QwenImageModularPipelineFastTests

DN6 · 2025-11-04T12:52:02Z

tests/modular_pipelines/qwen/test_modular_pipeline_qwenimage.py

+    params = frozenset(["prompt", "height", "width", "negative_prompt", "attention_kwargs", "image", "mask_image"])
+    batch_params = frozenset(["prompt", "negative_prompt", "image", "mask_image"])
+
+    def get_pipeline(self, components_manager=None, torch_dtype=torch.float32):


Can just use the one defined in ModularPipelineTesterMixin

DN6 · 2025-11-04T12:52:36Z

tests/modular_pipelines/qwen/test_modular_pipeline_qwenimage.py

+        pipeline.set_progress_bar_config(disable=None)
+        return pipeline
+
+    def get_dummy_inputs(self, device, seed=0):


Can move into actual test object e.g. QwenImageModularPipelineFastTests

DN6 · 2025-11-04T12:52:45Z

tests/modular_pipelines/qwen/test_modular_pipeline_qwenimage.py

+        return inputs
+
+
+class QwenImageModularGuiderTests:


Suggested change

class QwenImageModularGuiderTests:

class QwenImageModularGuiderTesterMixin:

DN6 · 2025-11-04T12:53:19Z

tests/modular_pipelines/qwen/test_modular_pipeline_qwenimage.py

+class QwenImageModularPipelineFastTests(
+    QwenImageModularTests, QwenImageModularGuiderTests, ModularPipelineTesterMixin, unittest.TestCase


Remove unittest

Suggested change

class QwenImageModularPipelineFastTests(

QwenImageModularTests, QwenImageModularGuiderTests, ModularPipelineTesterMixin, unittest.TestCase

class TestQwenImageModularPipelineFast(

QwenImageModularTests, QwenImageModularGuiderTests, ModularPipelineTesterMixin

sayakpaul · 2025-11-04T13:12:46Z

I will wait for your #12579 PR to get merged first. Easier that way for me to apply your suggestions.

sayakpaul added 3 commits November 3, 2025 18:42

add tests for qwenimage modular.

e35962b

qwenimage edit.

94fa202

qwenimage edit plus.

7d3c250

sayakpaul requested review from DN6 and yiyixuxu November 4, 2025 04:37

sayakpaul added the modular-diffusers label Nov 4, 2025

sayakpaul commented Nov 4, 2025

View reviewed changes

Merge branch 'main' into qwen-modular

7334520

sayakpaul added 2 commits November 4, 2025 10:26

Merge branch 'main' into qwen-modular

92d7977

empty

7ad48f0

DN6 reviewed Nov 4, 2025

View reviewed changes

	img_shapes = [
	[
	(1, height // self.vae_scale_factor // 2, width // self.vae_scale_factor // 2),
	(1, calculated_height // self.vae_scale_factor // 2, calculated_width // self.vae_scale_factor // 2),
	]
	] * batch_size

		block_state.negative_prompt_embeds = None
		block_state.negative_prompt_embeds_mask = None

		from ..test_modular_pipelines_common import ModularPipelineTesterMixin


		class QwenImageModularTests:

	class QwenImageModularTests:
	class QwenImageModularTesterMixin:

	class QwenImageModularGuiderTests:
	class QwenImageModularGuiderTesterMixin:

		class QwenImageModularPipelineFastTests(
		QwenImageModularTests, QwenImageModularGuiderTests, ModularPipelineTesterMixin, unittest.TestCase

[modular] add tests for qwen modular #12585

Are you sure you want to change the base?

[modular] add tests for qwen modular #12585

Uh oh!

Conversation

sayakpaul commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sayakpaul Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HuggingFaceDocBuilderDev commented Nov 4, 2025

Uh oh!

sayakpaul commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DN6 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sayakpaul commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sayakpaul commented Nov 4, 2025 •

edited

Loading

sayakpaul Nov 4, 2025 •

edited

Loading

sayakpaul commented Nov 4, 2025 •

edited

Loading