Fix modular pipeline: check required before applying default in get_block_state - #14395
Closed
lorenzozanee wants to merge 0 commit into
Closed
Fix modular pipeline: check required before applying default in get_block_state#14395lorenzozanee wants to merge 0 commit into
lorenzozanee wants to merge 0 commit into
Conversation
Author
|
AI self-review: READY |
lorenzozanee
force-pushed
the
fix/modular-required-param-default
branch
from
August 5, 2026 13:52
326410b to
09514d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14388
InputParam.template("num_inference_steps", required=True) was silently ignored because get_block_state would substitute the template's default before checking required. This moves the required check before the default fallback.
AI self-review: READY
Validated: test_modular_pipelines_custom_blocks.py, test_conditional_pipeline_blocks.py, ruff, check_copies, check_dummies, check_support_list.
Upstream-only CI: pr_tests.yml (GPU jobs), pr_tests_gpu.yml, pr_modular_tests.yml, pr_dependency_test.yml, pr_torch_dependency_test.yml, build_documentation.yml, build_pr_documentation.yml, pr_style_bot.yml.