-
Notifications
You must be signed in to change notification settings - Fork 358
Add indextts snippet #1373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add indextts snippet #1373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Deep-unlearning, thanks for opening this PR! It looks really good already. Just left some comments to make the snippet more self-contained and future-proof.
Co-authored-by: Lucain <[email protected]>
Co-authored-by: Lucain <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but let's wait for https://huggingface.co/IndexTeam/Index-TTS to be correctly tagged before merging :)
(@Deep-unlearning can you ping here once it's the case?)
repoName: "IndexTTS", | ||
repoUrl: "https://github.com/index-tts/index-tts", | ||
snippets: snippets.indextts, | ||
filter: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filter: false, |
Default value, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but we put false
for all of the ones we don't want so prolly okay to keep it the way it is, unless we want to make the change for all.
No description provided.