Skip to content

Add MAGI-1 library #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add MAGI-1 library #1386

wants to merge 3 commits into from

Conversation

jiahy0825
Copy link

This PR adds MAGI-1 library

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jiahy0825 - Thanks for the PR, couple of quick notes:

  1. I see that instead of one model per repo, there are multiple different models in the same repo: https://huggingface.co/sand-ai/MAGI-1/tree/main/ckpt/magi
  2. Since all the model repos are diffusers repos, the download tracking should automatically work if these checkpoints were split in 3 repos.

Let me know if you have any questions.

@jiahy0825
Copy link
Author

Hi @jiahy0825 - Thanks for the PR, couple of quick notes:

  1. I see that instead of one model per repo, there are multiple different models in the same repo: huggingface.co/sand-ai/MAGI-1/tree/main/ckpt/magi
  2. Since all the model repos are diffusers repos, the download tracking should automatically work if these checkpoints were split in 3 repos.

Let me know if you have any questions.

Hi, thanks a lot for your reply!

We would like to keep all these models in a single repo because our model pipeline is relatively complex — it involves multiple components like T5, VAE, and others. Having all related models organized within one repo would make it much easier for users to find and use them together.

Therefore, we would prefer to track downloads through this repo via the PR if possible.

Please let me know if you have any better suggestions. Thanks again for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants