Update tiny-agent format to follow VSCode format #1556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-c
approved these changes
Jun 25, 2025
| @@ -4,6 +4,7 @@ import * as readline from "node:readline/promises"; | |||
| import { stdin, stdout } from "node:process"; | |||
| import { z } from "zod"; | |||
| import { PROVIDERS_OR_POLICIES } from "@huggingface/inference"; | |||
| import type { ServerConfig } from "@huggingface/mcp-client"; | |||
There was a problem hiding this comment.
a bit confusing to have the same name for something different in mcp-client vs. tiny-agent, but I guess this one's on me 😀
i guess we could potentially rename the one in mcp-client to McpServerConfig but 🤷
hanouticelina
approved these changes
Jun 30, 2025
There was a problem hiding this comment.
looks good, thank you!
EDIT: We should remove the "config" nested mapping in https://github.com/huggingface/huggingface.js/blob/main/packages/tiny-agents/test/ServerConfigSchema.spec.ts
Indeed! Done in 477c01d |
This was referenced Jul 7, 2025
Wauplin
added a commit
that referenced
this pull request
Jul 7, 2025
Fix docs example after huggingface/huggingface_hub#3166 / #1556. Since release [0.33.2](https://github.com/huggingface/huggingface_hub/releases/tag/v0.33.2) `tiny-agents` config follow VSCode format. We made the change without a proper deprecation warning as it's still experimental and we wanted to harmonize with VSCode as quickly as possible (to avoid future conflicts). Related PRs: - huggingface/hub-docs#1816 - huggingface/transformers#39245 - huggingface/huggingface_hub#3205 - #1599
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same PR as huggingface/huggingface_hub#3166 in Python.
This PR introduces breaking changes but I think it's best to do it now. Goal is to have the same format as VSCode MCP config e.g.
{ "model": "Qwen/Qwen2.5-72B-Instruct", "provider": "nebius", "inputs": [ { "type": "promptString", "id": "hf-token", "description": "Token for Hugging Face API access", "password": true } ], "servers": [ { "type": "http", "url": "https://huggingface.co/mcp", "headers": { "Authorization": "Bearer ${input:hf-token}" } } ] }breaking changes:
confignested mapping => everything at root levelheadersat root level instead of inside options.requestInitOnce this PR and huggingface/huggingface_hub#3166 are approved, we can merge + release them at the same time + update the config in https://huggingface.co/datasets/tiny-agents/tiny-agents to follow the new convention. For now, only wauplin/library-pr-reviewer has been updated for testing.
EDIT: PR merged and released. Made a release on Python SDK as well and updated all configs in https://huggingface.co/datasets/tiny-agents/tiny-agents.