Fix: Avoid empty keyword argument in VLLMModelConfig from Makefile #246
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Summary
When running the make evaluate command with the specified parameters, an error occurs indicating that the VLLMModelConfig initializer received an unexpected keyword argument.
Steps to Reproduce:
Expected Behavior: The evaluation process should complete without errors, utilizing the specified model and task parameters.
Actual Behavior: The following error message is displayed:
Root Cause Analysis
Proposed Solution
Modify the
MODEL_ARGS
assignment in the Makefile to conditionally include$(PARALLEL_ARGS)
only if it's not empty:This prevents the introduction of an unintended empty string argument.
Testing