Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although in theory we should allocate a big buffer for reasoning models to play with before giving out final answers, in practice, our generation can never be that long (in fact, the
max_completion_length
parameter for model training is usually clipped at 1024). So it doesn't make sense to use 32768 as the max length for generation.Changing 32768 to 4096 would also resolve some issues because 32768 is too long as the default length for some models