-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified installation requirements to support more accelerators #303
Open
ji-huazhong
wants to merge
1
commit into
huggingface:main
Choose a base branch
from
ji-huazhong:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use the vllm on the Ascend NPU, you need to install the vllm-ascend plug-in https://github.com/vllm-project/vllm-ascend. Refer to the GRPO usage example in readme and run the following command: ACCELERATE_LOG_LEVEL=info accelerate launch --config_file recipes/accelerate_configs/zero2.yaml \
--num_processes=7 src/open_r1/grpo.py \
--config recipes/Qwen2.5-1.5B-Instruct/grpo/config_demo.yaml The following is the part of printout during the training process:
|
This PR helps a lot, I hope it can speed up the integration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We aim to explore the feasibility of reproducing DeepSeek R1 on an Ascend NPU, capitalizing on the existing implementation found in this repository. The Hugging Face ecosystem, which encompasses tools such as Transformers, accelerate, peft, trl, and safetensors, already provides robust support for a variety of accelerators beyond NVIDIA GPUs, including Ascend NPU and Intel XPU, among others
This PR introduces minor changes to installation prerequisites to allow open-r1 to run out of the box on third-party accelerators.
In addition, to speed up the generation of training samples, the
GRPOTrainer
in trl was modified to support the use of vllm on non-CUDA devices. A PR(huggingface/trl#2836) is also submitted for this modification.Closes: #44
cc @qgallouedec @lewtun