Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Transformers v4.48 #1698

Draft
wants to merge 83 commits into
base: main
Choose a base branch
from
Draft

Upgrade to Transformers v4.48 #1698

wants to merge 83 commits into from

Conversation

regisss
Copy link
Collaborator

@regisss regisss commented Jan 15, 2025

What does this PR do?

As per title.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

regisss and others added 30 commits September 2, 2024 16:51
@yafshar
Copy link
Contributor

yafshar commented Feb 6, 2025

@regisss can you please cherry pick this huggingface/transformers#35438 to this branch. It is relevant to def training_step(

with self.compute_loss_context_manager():

@regisss
Copy link
Collaborator Author

regisss commented Feb 7, 2025

@regisss can you please cherry pick this huggingface/transformers#35438 to this branch. It is relevant to def training_step(

with self.compute_loss_context_manager():

@yafshar huggingface/transformers#35438 was introduced in v4.48.0 and I cherry-picked later huggingface/transformers#35651 that fixes it. Is there anything specific to huggingface/transformers#35438 that you would like to have here?

@yafshar
Copy link
Contributor

yafshar commented Feb 7, 2025

@regisss can you please cherry pick this huggingface/transformers#35438 to this branch. It is relevant to def training_step(

with self.compute_loss_context_manager():

@yafshar huggingface/transformers#35438 was introduced in v4.48.0 and I cherry-picked later huggingface/transformers#35651 that fixes it. Is there anything specific to huggingface/transformers#35438 that you would like to have here?

Thanks, in that case no need for any change (my mistake). I was working on an older commit and encountered the issue which is fixed in this commit and has been changed later.

regisss and others added 23 commits February 7, 2025 18:31
Use super class self.scaling for scale.
Co-authored-by: Sayantan Sarkar <[email protected]>
Signed-off-by: Daniel Socek <[email protected]>
Co-authored-by: Daniel Socek <[email protected]>
Co-authored-by: regisss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.