Skip to content

ENH: Orthogonal LoRA layer initialization (2) #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BenjaminBossan
Copy link
Member

Continuation of, and supersedes #2389

Check discussion there for further info.

Continuation of, and supersedes huggingface#2389

Check discussion there for further info.
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@BenjaminBossan
Copy link
Member Author

BenjaminBossan commented Apr 15, 2025

I compared the results with orthogonal init vs normal and Gaussian LoRA init, with all other parameters kept equal, using the MetaMathQA method comparison suite. Test accuracy on GSMK8K improved is 47.8% for default, 49.3% for Gaussian, and 48.9% for orthogonal. As expected, memory usage and runtime are practically identical.

I also plotted the train loss:

image

There seems to be a slight advantage for orthogonal initialization there is well, though for the first half of the run, it lags behind the other methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants