Fix Qwen3 when --dtype float16
on CPU / MPS
#653
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is a follow up fix of #648, since the
float16
inference for Qwen3 models was broken due to theattention_bias
dtype, which was defaulting tofloat32
, so this PR adds thedtype
field forQwen3Model
so that the dtype is inherited.As a side-fix, this PR also removes the
to_device
method fromTensor::zeros_like
as it's not required, and by default placed in the same device as the tensor used.Before submitting
Who can review?
@Narsil or @kozistr