Update conversion mapping to separate renaming from converting #42254
+525
−329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Cyrilvallez
reviewed
Nov 19, 2025
Member
Cyrilvallez
left a comment
Cyrilvallez
left a comment
There was a problem hiding this comment.
All right! Much simpler than before!
Did not check in details all the complex regex patterns for edge cases though, but they look similar to before
The only thing I'm really not a fan of, is the double WeightRenaming + WeightConverter for the same keys -> IMO if we need any Operation, then we should simply have a WeightConverter correctly specifying sources and targets
Comment on lines
284
to
353
| if not targets_were_none and bool(len(self.source_keys) - 1) + bool(len(self.target_keys) - 1) >= 2: | ||
| if bool(len(self.source_keys) - 1) + bool(len(self.target_keys) - 1) >= 2: |
Member
There was a problem hiding this comment.
nit: I'd rather have this without the bool - makes it harder to understand instead of simpler patterns IMO
vasqu
reviewed
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the conversion:
to support torchao
