Make Disk Cache Configurable by environment variable #196
+70
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylow
changed the title
|
My only concern with this PR is that the unit-tests don't actually confirm that chunk cache behaves as expected when capacity set. If there was an integration test that would cover that case I would feel better. |
assafvayner
reviewed
Mar 21, 2025
| @@ -32,6 +33,14 @@ const MAX_CONCURRENT_DOWNLOADS: usize = 8; // Download is not CPU-bound | |||
| const DEFAULT_CAS_ENDPOINT: &str = "http://localhost:8080"; | |||
| const READ_BLOCK_SIZE: usize = 1024 * 1024; | |||
|
|
|||
| fn get_configured_cache_size() -> u64 { | |||
| env::var("HF_XET_CACHE_SIZE_GB") | |||
There was a problem hiding this comment.
should use new configurable_constants! macro for this here, if needs to rebase off main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the chunk cache configurable through environment variable, specifically HF_XET_CACHE_SIZE_GB. Defaults to 10GB. Setting it to 0 disables the chunk cache.