make utils wasm compat #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assafvayner
force-pushed
the
assaf/utils-mods
branch
from
6108116 to
2618685
Compare
seanses
reviewed
Mar 21, 2025
| @@ -4,6 +4,7 @@ | |||
| /// * `v` - the size in bytes | |||
| pub fn output_bytes(v: usize) -> String { | |||
| let map = vec![ | |||
| #[cfg(not(target_family = "wasm"))] | |||
There was a problem hiding this comment.
Is there a way to tell if it's wasm32 or wasm64? I think this is only invalid in wasm32
There was a problem hiding this comment.
Actually.. maybe a better fix is to change the parameter type to u64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the utils crate (singleflight, serialization_utils) compiles for WASM, should be rebased/merge-main after the xet_threadpool change #204 is in main.